🎨Only require sticky connection on specific endpoints (🚨🚨) #7839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
the
a:webserver
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7839 +/- ##
==========================================
+ Coverage 87.89% 87.93% +0.04%
==========================================
Files 1837 1830 -7
Lines 71032 70842 -190
Branches 1219 1219
==========================================
- Hits 62434 62296 -138
+ Misses 8255 8203 -52
Partials 343 343
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
force-pushed
the
only-required-sticky-endpoints
branch
2 times, most recently
from
398cf31 to
a14651e
Compare
sanderegg
changed the title
sanderegg
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66 and
pcrespov
sanderegg
commented
Jun 10, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR scopes sticky session routing to only the required endpoints and increases the webserver replica count to improve resilience and allow early detection of in-process tasks.
- Scale webserver service to 2 replicas for early detection of in-process tasks
- Remove global sticky session labels and introduce a dedicated Traefik service/router for specific endpoints
- Clean up blank lines in compose files and add new Python extra paths in VSCode settings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/docker-compose.yml | Added replicas: 2, removed global sticky labels, introduced dedicated sticky service |
| services/docker-compose.local.yml | Updated local sticky service label and secure flag |
| .vscode/settings.template.json | Added common-library and dask-task-models-library to Python extraPaths |
Comments suppressed due to low confidence (2)
services/docker-compose.local.yml:162
- [nitpick] Consider adding
sticky.cookie.httponlyandsticky.cookie.samesitelabels in local compose, so dev mirrors production cookie security settings.
- - traefik.http.services.${SWARM_STACK_NAME}_webserver_sticky.loadbalancer.sticky.cookie.secure=false
services/docker-compose.yml:1359
- [nitpick] This single-line array is harder to read and maintain compared to the previous multiline format; consider restoring multiline YAML for clarity.
[ "redis-server", "--save", "60 1", "--loglevel", "verbose", "--databases", "10", "--appendonly", "yes", "--requirepass", "${REDIS_PASSWORD}" ]
giancarloromeo
approved these changes
Jun 10, 2025
mrnicegyu11
approved these changes
Jun 10, 2025
Member
mrnicegyu11
left a comment
mrnicegyu11
left a comment
There was a problem hiding this comment.
very very nice effort, thx
sanderegg
force-pushed
the
only-required-sticky-endpoints
branch
from
2b9a1f2 to
0ce2954
Compare
GitHK
approved these changes
Jun 11, 2025
matusdrobuliak66
approved these changes
Jun 11, 2025
YuryHrytsuk
reviewed
Jun 11, 2025
Contributor
YuryHrytsuk
left a comment
YuryHrytsuk
left a comment
There was a problem hiding this comment.
Please, let me know what is the exact requirement for static-webserver replica's count.
I will then create a corresponding PR for osparc-ops-environments repo
sanderegg
force-pushed
the
only-required-sticky-endpoints
branch
from
0ce2954 to
3406ee6
Compare
sanderegg
added
🤖-automerge
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at cf51daf |
sanderegg
force-pushed
the
only-required-sticky-endpoints
branch
from
3406ee6 to
72c3fb2
Compare
|
This was referenced Jun 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
only require sticky connection for
These entrypoints rely on in-process tasks to be available, otherwise these actions fail.
Once the tasks get completely process agnostic, the sticky connection shall be completely removed and then scaling up webservers shall have a direct effect when the number of users increases (see #7778).
Also this PR sets the number of replicas of the webserver to 2 to decrease the chances of adding in-process tasks again.
NOTE: This is a rather risky PR on which we agreed to merge only after the current release
Related issue/s
How to test
Dev-ops